-
Notifications
You must be signed in to change notification settings - Fork 591
Don't write reaction rates in depletion results by default, remove per-stage data for multistage integrators #3609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't write reaction rates in depletion results by default, remove per-stage data for multistage integrators #3609
Conversation
eepeterson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few initial comments, but I like the tidying up of getting rid of sub-step info.
|
Thanks @eepeterson; comments have just been addressed. |
eepeterson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more comments from me
Description
This PR makes two important changes in our depletion_results.h5 files:
integrator.integrate(..., write_rates=True)Fixes #3602
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)